-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unitaryhack] add exponential wrapper class #28
[unitaryhack] add exponential wrapper class #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so so much for your contribution! This is great!
May I ask that you write some tests for this though? For both the new Exponential class and for serde. You can use this PR as a template for your tests.
Sure! I was in the middle of preparing them 😄 |
This solves zapata-engineering/orquestra-core#15 |
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 94.29% 94.32% +0.03%
==========================================
Files 68 68
Lines 5570 5621 +51
==========================================
+ Hits 5252 5302 +50
- Misses 318 319 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks so much for your contribution! Can I have your email so our legal department send you a CLA so that we can add your contribution to our codebase! If you don't want to post it here you can just email me at athena.ceasura@zapatacomputing.com and we'll get it to you.
Also, the T-shirt offer still stands. 😉
Hi @AthenaCaesura thanks for your message. I've just saw it! For some reason the emails I've just sent you were blocked, but I think @mstechly already have my email. |
Description
Implement a class exponential wrapper around the Gate Protocol.
Please verify that you have completed the following steps